Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Properly invoke update command when needed after normalization #135

Merged
merged 2 commits into from Dec 24, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 23, 2018

This PR

  • asserts that the command succeeds when composer.lock is present and fresh before normalization and composer.json is not yet normalized
  • properly invokes the update command

Follows #109.
Follows #129.

@localheinz localheinz added the bug label Dec 23, 2018
@localheinz localheinz self-assigned this Dec 23, 2018
@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #135 into 1.x will increase coverage by 4.14%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.x     #135      +/-   ##
============================================
+ Coverage     77.51%   81.65%   +4.14%     
  Complexity       34       34              
============================================
  Files             2        2              
  Lines           169      169              
============================================
+ Hits            131      138       +7     
+ Misses           38       31       -7
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 86.25% <100%> (+4.37%) 31 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d6dda...70888c8. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #135 into 1.x will increase coverage by 4.14%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.x     #135      +/-   ##
============================================
+ Coverage     77.51%   81.65%   +4.14%     
  Complexity       34       34              
============================================
  Files             2        2              
  Lines           169      169              
============================================
+ Hits            131      138       +7     
+ Misses           38       31       -7
Impacted Files Coverage Δ Complexity Δ
src/Command/NormalizeCommand.php 86.25% <100%> (+4.37%) 31 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d6dda...0dce070. Read the comment docs.

@localheinz localheinz force-pushed the fix/update branch 3 times, most recently from 8c3b998 to 0dce070 Compare December 24, 2018 09:26
@localheinz localheinz merged commit b6da87d into 1.x Dec 24, 2018
@localheinz localheinz deleted the fix/update branch December 24, 2018 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant