Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Update localheinz/json-normalizer #78

Merged
merged 4 commits into from Nov 4, 2018

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Sep 8, 2018

This PR

  • updates localheinz/json-normalizer
  • adjusts normalizers to follow modified method signature
  • adjusts NormalizerCommand to work with newly created value objects
  • removes tests which are difficult to maintain

Fixes #99.

💁‍♂️ For reference, see ergebnis/json-normalizer@0.6.0...0.8.0.

@localheinz localheinz self-assigned this Sep 8, 2018
@localheinz localheinz mentioned this pull request Sep 8, 2018
1 task
@localheinz localheinz force-pushed the feature/json-normalizer branch 2 times, most recently from bf90c93 to 59b412e Compare October 3, 2018 20:58
@localheinz localheinz force-pushed the feature/json-normalizer branch 5 times, most recently from 1cbb136 to 9f468f5 Compare October 9, 2018 18:53
@codecov
Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #78 into master will decrease coverage by 27.27%.
The diff coverage is 78.94%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #78       +/-   ##
=============================================
- Coverage       100%   72.72%   -27.28%     
+ Complexity       71       63        -8     
=============================================
  Files             7        7               
  Lines           272      264        -8     
=============================================
- Hits            272      192       -80     
- Misses            0       72       +72
Impacted Files Coverage Δ Complexity Δ
src/Normalizer/VersionConstraintNormalizer.php 96.55% <100%> (-3.45%) 8 <6> (-1)
src/Normalizer/ComposerJsonNormalizer.php 100% <100%> (ø) 3 <2> (-2) ⬇️
src/Normalizer/BinNormalizer.php 100% <100%> (ø) 4 <4> (-2) ⬇️
src/Normalizer/ConfigHashNormalizer.php 94.73% <100%> (-5.27%) 6 <6> (-1)
src/Normalizer/PackageHashNormalizer.php 100% <100%> (ø) 7 <5> (-2) ⬇️
src/Command/NormalizeCommand.php 55.69% <42.85%> (-44.31%) 32 <10> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 153f88c...0b1576e. Read the comment docs.

@localheinz localheinz merged commit 7e1817a into master Nov 4, 2018
@localheinz localheinz deleted the feature/json-normalizer branch November 4, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant