Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web share (without internet) #198

Closed
jerryn70 opened this issue Feb 23, 2023 · 9 comments
Closed

Web share (without internet) #198

jerryn70 opened this issue Feb 23, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@jerryn70
Copy link

Having a web share option (without internet) in this app is good feature to send files to others those who don't have localsend app installed on their phone .

Currently we have to force other's to install localsend app on their device to send file. With this feature that problem will be solved. There is an app called 'sharex' on fdroid with this feature you can check it out for reference.

@Tienisto Tienisto added the enhancement New feature or request label Feb 24, 2023
@yurenchen000
Copy link

https://github.com/localsend/protocol/blob/284d95af/README.md#3-file-transfer-http

I guess with current protocol,
browser can upload(send) file to localsend app easily.(just little web page, and manually input app address)

but is unable to download(receive) file yet

@Tienisto
Copy link
Member

Tienisto commented Mar 7, 2023

This feature is planned for the next release v1.9.0. Maybe in a few weeks but it depends how much time I have

This was referenced Mar 30, 2023
@septs
Copy link
Contributor

septs commented Apr 5, 2023

Compatibility with snapdrop1 is a possible low-cost solution

https://github.com/RobinLinus/snapdrop/blob/master/server/index.js

Footnotes

  1. https://snapdrop.net

@Tienisto
Copy link
Member

Tienisto commented Apr 5, 2023

@septs Isn't SnapDrop using WebRTC?

@yurenchen000
Copy link

yurenchen000 commented Apr 5, 2023

yes,
It (the webRTC that snapdrop has based on) need a common p2p server for peer-to-peer discover.


I have also considered using webrtc for p2p communication in web pages.
But it relies on a p2p server pre-specified on both clients.

Seems inconvenient to implement on a network without internet.

@Tienisto
Copy link
Member

Tienisto commented Apr 5, 2023

We don't need p2p discover when the file transfer only happens in one direction. This avoids problems where one client has no permission to start a HTTP server.

@Tienisto
Copy link
Member

Tienisto commented Apr 5, 2023

@yurenchen000 Yes, WebRTC is the reason why LocalSend has been created. I wanted a solution where you don't need any external server.

@yurenchen000
Copy link

yurenchen000 commented Apr 5, 2023

yes,
that's why we are here 😂


It seems that the negotiation server in the WebRTC protocol cannot be omitted,
Even if both parties can guess the peer address.

(I'm not quite sure,
I just roughly flipped through the communication steps and demo code of WebRTC.

@Tienisto
Copy link
Member

Implemented. Will be released in the coming v1.9.0 update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants