Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multithreading #491

Open
Tienisto opened this issue May 29, 2023 · 6 comments
Open

Enable multithreading #491

Tienisto opened this issue May 29, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Tienisto
Copy link
Member

Run the server in a separate thread.

For each file to be sent, start a separate thread.

By moving the file transfer out of the main thread, transmission speeds should increase by around 25%

@Tienisto Tienisto added the enhancement New feature or request label May 29, 2023
@Tienisto Tienisto self-assigned this May 29, 2023
@Tienisto Tienisto mentioned this issue May 29, 2023
7 tasks
@SelaseKay
Copy link
Contributor

Can I assist with this if you need any?

@Tienisto
Copy link
Member Author

Tienisto commented Jun 1, 2023

This will be difficult as I am currently extracting the core logic to a standalone package. This refactoring is needed so we can implement a LocalSend CLI without Flutter.

@SelaseKay
Copy link
Contributor

Alright. That sounds reasonable.

@KraXen72
Copy link

it might not be the best idea to start over 20 or so threads, but i assume you are going to add some sort of limit to the active threads number. From the wording of the issue, it kind of sounds like each file in the transfer queue get's their own thread, potentially creating like, for example, 1 000 threads.

@microboym
Copy link

To speed up the transferring progress, enabling use to use a 3rd-part download manager (eg. Aria2) may be a solution.

@Pentaphon
Copy link

Pentaphon commented Apr 30, 2024

To speed up the transferring progress, enabling use to use a 3rd-part download manager (eg. Aria2) may be a solution.

That seems like it over-complicates things. I'd rather have localsend work faster with a separate thread and then have the community optimize the standalone process with any frontends we can create. I am looking forward to a Kotlin version of Localsend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants