Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to package managers in Windows #57

Closed
3 tasks done
sitiom opened this issue Jan 29, 2023 · 19 comments · Fixed by #396
Closed
3 tasks done

Add to package managers in Windows #57

sitiom opened this issue Jan 29, 2023 · 19 comments · Fixed by #396
Labels
enhancement New feature or request

Comments

@sitiom
Copy link
Contributor

sitiom commented Jan 29, 2023

Here is a checklist:

Can you add an MSIX installer in the releases so I can add LocalSend to Winget? Thanks.

@Tienisto
Copy link
Member

Hi, thanks. I need to figure out how to sign first. Currently, Microsoft signs this automatically when published to the Windows Store.

@Tienisto Tienisto added the enhancement New feature or request label Jan 29, 2023
@Tienisto
Copy link
Member

I have added one: https://github.com/localsend/localsend/releases/download/v1.6.2/LocalSend-1.6.2.msix

Let me know if something is wrong. Thank you!

@sitiom
Copy link
Contributor Author

sitiom commented Jan 29, 2023

Hi, seems like it needs a self-signed certificate, which cannot be added to Winget:
image

Can't you somehow publish the Microsoft store-signed MSIX instead?

@Tienisto
Copy link
Member

Tienisto commented Jan 29, 2023

I updated the msix release asset. Can you test it again please?

@sitiom
Copy link
Contributor Author

sitiom commented Jan 30, 2023

Thanks, that works. Working on adding it to Winget now!

@Tienisto
Copy link
Member

Nice! Thank you very much!

@sitiom sitiom changed the title Add MSIX installer in the releases Add to package managers in Windows Jan 30, 2023
@sitiom
Copy link
Contributor Author

sitiom commented Jan 30, 2023

Here is the PR for Winget:

Once it is merged, the Winget Releaser workflow would have to be set up in this repo for automatic package updates.

@Tienisto
Copy link
Member

Wow thanks!

@Tienisto
Copy link
Member

Somehow the app was removed from the Microsoft store so I am unable to provide signed msix packages anymore. I contacted Microsoft to find a way to restore the account but they answered me this:

Hello,
Microsoft removed your developer account from the Microsoft Store based on good faith and reasonable evidence of activities that violate the terms of the account agreement.
The account agreement allows Microsoft to remove a Microsoft Store Account for abuse of the marketplace or failure to keep your account in good standing. Termination of your account results in the removal of associated application(s) from the store. Also, the account agreement allows Microsoft to remove an application from availability in the store for breach of the agreement or for any other reason.
We have determined that the removal of your account and published app(s) were warranted based on abusive and/or inappropriate activities. Please note that our decision is final, and when one account is in violation of the Agreement, we may also remove any related accounts.

Thank you,
Microsoft Store Team

@sitiom
Copy link
Contributor Author

sitiom commented Mar 1, 2023

Did you ask for the exact reason for the suspension? Maybe you can repeal to reactivate your account again.

@Tienisto
Copy link
Member

Tienisto commented Mar 1, 2023

Unfortunately, it didn't work. Created #220

@sitiom
Copy link
Contributor Author

sitiom commented Mar 1, 2023

If you don't get your account back, you can get a code signing certificate which is the more expensive route. Or provide MSI installers.

@Tienisto
Copy link
Member

Tienisto commented Mar 1, 2023

Yeah, I will find an alternative option.

@sitiom
Copy link
Contributor Author

sitiom commented Mar 9, 2023

Updates on this? The Winget version is outdated.

@Tienisto
Copy link
Member

Tienisto commented Mar 9, 2023

I bought a license from signmycode.com and I am still waiting for approval

@Tienisto
Copy link
Member

Tienisto commented Mar 10, 2023

@sitiom I have added the msix to the release asset. Can you verify that it is signed correctly?

@Tienisto
Copy link
Member

I have noticed that it is treated as a different application because of the different certificate. I don't know if it's an issue

@sitiom
Copy link
Contributor Author

sitiom commented Mar 11, 2023

We'll see about that. I've made a PR for 1.8.0 now: microsoft/winget-pkgs#99181

@dtantono
Copy link

@sitiom chocolatey-community/chocolatey-package-requests#1410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants