Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOC-40 ⁃ Use docker-compose.yml for autostart: true #23

Closed
sync-by-unito bot opened this issue Nov 13, 2020 · 3 comments
Closed

LOC-40 ⁃ Use docker-compose.yml for autostart: true #23

sync-by-unito bot opened this issue Nov 13, 2020 · 3 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Nov 13, 2020

The current implementation depends on user having to install localstack binary on their machine since it uses the following command (https://github.com/localstack/serverless-localstack/blob/master/src/index.js#L332) to start docker container.

localstack infra start --docker

This repo comes with a docker-compose.yml but it's not used at all.

IMHO, when auto-starting it should use the docker-compose.yml as the default way to start docker container. The reason being, I want to use locastack but I don't want to install the binary locally on my machine. That's the essence of using docker containers.

┆Issue is synchronized with this Jira Task by Unito

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 13, 2020

➤ ChunTing Wu commented:

I also face this problem. I am wondering if you solve this.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 13, 2020

➤ Azizur Rahman commented:

I also face this problem. I am wondering if you solve this.

I have actually decided for my use case, I could live without localstack. I guess I did not have time to explore this more since maintainers on the project did not comment.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 13, 2020

➤ Waldemar Hummer commented:

Thanks for reporting azizur wirelessr , and apologies for the delay. Please note that pull requests are highly welcomed and encouraged, if you'd like to see a certain functionality being added!

To explore your proposal a bit more - I guess we could add a configuration switch that allows users to define whether they want to use the localstack command line versus the docker-compose command. (Please note that not all users may have docker-compose installed, either).

wirelessr Do you think you could try to create a pull request to add this functionality? We'd be happy to provide help and guidance, as needed. Thanks for your help!

@miho120 miho120 closed this as completed Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant