Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker location missing in the list #38

Closed
nazymko opened this issue Feb 10, 2021 · 2 comments
Closed

Docker location missing in the list #38

nazymko opened this issue Feb 10, 2021 · 2 comments

Comments

@nazymko
Copy link

nazymko commented Feb 10, 2021

Currently, the library looking for a docker executable in few places, but the latest docker installation has it in docker\resources\docker.exe
C:\Program Files\Docker\Docker\resources\docker.exe
but it looking for a file in the 'bin' folder
C:\Program Files\Docker\Docker\resources*bin*\docker.exe

List of possible locations have to be updated

cloud.localstack.docker.exception.LocalstackDockerException: Could not start the localstack docker container. at cloud.localstack.Localstack.startup(Localstack.java:90) at cloud.localstack.LocalstackTestRunner.run(LocalstackTestRunner.java:41) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69) at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33) at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:220) at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:53) Caused by: java.lang.IllegalStateException: Cannot find docker executable. at cloud.localstack.docker.DockerExe.lambda$getDockerExeLocation$1(DockerExe.java:43) at java.base/java.util.Optional.orElseThrow(Optional.java:408) at cloud.localstack.docker.DockerExe.getDockerExeLocation(DockerExe.java:43) at cloud.localstack.docker.DockerExe.<init>(DockerExe.java:35) at cloud.localstack.docker.command.Command.<init>(Command.java:11)

@whummer
Copy link
Member

whummer commented Feb 10, 2021

Thanks for reporting @nazymko . Do you think you could create a small pull request with this change? That would be much appreciated - many thanks for your help!

@nazymko
Copy link
Author

nazymko commented Feb 11, 2021

This location was added recently to 0.2.7 (I was using 0.2.5)

@nazymko nazymko closed this as completed Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants