Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce BackendStateLifecycle abstraction #6114

Merged
merged 6 commits into from May 27, 2022

Conversation

giograno
Copy link
Member

@giograno giograno commented May 21, 2022

Minor changes to the abstraction used to retrieve the state of a service.
Mainly renaming and variable keyword arguments to give us some rooms to support different level-of-depth of persistence.
This abstract class will be implemented by BackendStateLifecycleBase that handles services that use BackendDict and RegionBackend. BackendStateExternalLifecycle will be a specialization for services with external assets.

classDiagram
      BackendStateLifecycle <|-- BackendStateLifecycleBase
      BackendStateLifecycleBase <|-- BackendStateExternalLifecycle

Note: StateLifecycle can be removed after ext changes are merged.

@giograno giograno requested review from whummer and thrau May 21, 2022 11:15
@giograno giograno temporarily deployed to localstack-ext-tests May 21, 2022 11:15 Inactive
@github-actions
Copy link

github-actions bot commented May 21, 2022

LocalStack integration with Pro

0 files   -        3  0 suites   - 3   0s ⏱️ - 1h 6m 3s
0 tests  - 1 059  0 ✔️  - 1 026  0 💤  - 33  0 ±0 
0 runs   - 1 355  0 ✔️  - 1 295  0 💤  - 60  0 ±0 

Results for commit e198054. ± Comparison against base commit 5f46aca.

♻️ This comment has been updated with latest results.

@giograno giograno marked this pull request as draft May 21, 2022 12:05
@giograno giograno force-pushed the introducing-backend-state-lifecycle branch from 21e919f to 12bb3be Compare May 24, 2022 18:08
@giograno giograno temporarily deployed to localstack-ext-tests May 24, 2022 18:08 Inactive
@giograno giograno temporarily deployed to localstack-ext-tests May 24, 2022 21:00 Inactive
@giograno giograno temporarily deployed to localstack-ext-tests May 24, 2022 21:02 Inactive
@giograno giograno force-pushed the introducing-backend-state-lifecycle branch from df44ad8 to eb7feac Compare May 24, 2022 21:03
@giograno giograno temporarily deployed to localstack-ext-tests May 24, 2022 21:03 Inactive
@giograno giograno force-pushed the introducing-backend-state-lifecycle branch from eb7feac to 3f0ee61 Compare May 24, 2022 21:03
@giograno giograno temporarily deployed to localstack-ext-tests May 24, 2022 21:04 Inactive
@giograno giograno temporarily deployed to localstack-ext-tests May 26, 2022 16:22 Inactive
This replaces StateLifecycle.
The concept of assets is removed from the API. Each services that does
operations with the state handles the level of persistence to support
(and therefore, the deep persistence)
(cherry picked from commit 0f7b5a7e41498ce88cab9c24a9c41d423da382a4)
(cherry picked from commit 117752d)
@giograno giograno force-pushed the introducing-backend-state-lifecycle branch from a5e6a3b to e198054 Compare May 26, 2022 19:50
@giograno giograno temporarily deployed to localstack-ext-tests May 26, 2022 19:50 Inactive
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @giograno , looking forward to seeing this in action! 👍

@whummer whummer marked this pull request as ready for review May 27, 2022 18:18
@whummer whummer changed the title Introduce BaseBackendStateLifecycle abstraction Introduce BackendStateLifecycle abstraction May 27, 2022
@giograno giograno merged commit b819cb4 into master May 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2022
@alexrashed alexrashed deleted the introducing-backend-state-lifecycle branch June 7, 2022 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants