New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce BackendStateLifecycle abstraction #6114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giograno
force-pushed
the
introducing-backend-state-lifecycle
branch
from
May 24, 2022 18:08
21e919f
to
12bb3be
Compare
giograno
force-pushed
the
introducing-backend-state-lifecycle
branch
from
May 24, 2022 21:03
df44ad8
to
eb7feac
Compare
giograno
force-pushed
the
introducing-backend-state-lifecycle
branch
from
May 24, 2022 21:03
eb7feac
to
3f0ee61
Compare
This replaces StateLifecycle. The concept of assets is removed from the API. Each services that does operations with the state handles the level of persistence to support (and therefore, the deep persistence)
…t running(to be removed)
(cherry picked from commit 0f7b5a7e41498ce88cab9c24a9c41d423da382a4) (cherry picked from commit 117752d)
giograno
force-pushed
the
introducing-backend-state-lifecycle
branch
from
May 26, 2022 19:50
a5e6a3b
to
e198054
Compare
whummer
approved these changes
May 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @giograno , looking forward to seeing this in action! 👍
whummer
changed the title
Introduce BaseBackendStateLifecycle abstraction
Introduce BackendStateLifecycle abstraction
May 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to the abstraction used to retrieve the state of a service.
Mainly renaming and variable keyword arguments to give us some rooms to support different level-of-depth of persistence.
This abstract class will be implemented by
BackendStateLifecycleBase
that handles services that useBackendDict
andRegionBackend
.BackendStateExternalLifecycle
will be a specialization for services with external assets.Note:
StateLifecycle
can be removed after ext changes are merged.