Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement request: SNS FilterPolicy extras support #9738

Closed
1 task done
robinduckett opened this issue Nov 27, 2023 · 3 comments · Fixed by #10691
Closed
1 task done

enhancement request: SNS FilterPolicy extras support #9738

robinduckett opened this issue Nov 27, 2023 · 3 comments · Fixed by #10691
Assignees
Labels
aws:sns Amazon Simple Notification Service status: backlog Triaged but not yet being worked on type: feature New feature, or improvement to an existing feature

Comments

@robinduckett
Copy link

robinduckett commented Nov 27, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Enhancement description

AWS has added extra features to their SNS filter policy system and the LocalStack SNS does not support them:

The features as noted by @bram-tv:

$or operator
suffix matching
case insensitive matching ("equals-ignore-case")

🧑‍💻 Implementation

No response

Anything else?

More info:

@robinduckett robinduckett added status: triage needed Requires evaluation by maintainers type: enhancement labels Nov 27, 2023
@localstack-bot
Copy link
Collaborator

Welcome to LocalStack! Thanks for reporting your first issue and our team will be working towards fixing the issue for you or reach out for more background information. We recommend joining our Slack Community for real-time help and drop a message to LocalStack Pro Support if you are a Pro user! If you are willing to contribute towards fixing this issue, please have a look at our contributing guidelines and our contributing guide.

@bentsku bentsku added aws:sns Amazon Simple Notification Service status: backlog Triaged but not yet being worked on and removed status: triage needed Requires evaluation by maintainers labels Nov 27, 2023
@bram-tv
Copy link

bram-tv commented Feb 24, 2024

The title of this issue is (slightly) misleading (and one could argue also incomplete).

Based on the whats-new post: what was added to SNS filtering:

The title of this issue also mentions $and but that does not exist (+ the two other new additions are not included).

Note: that this also requires changes in moto for which I created getmoto/moto#7386

@robinduckett
Copy link
Author

robinduckett commented Feb 24, 2024

@bram-tv that’s fair, not sure how I misread that - any suggestions for a better title? Other than omitting the nonexistent operator

edit: updated title and description

@robinduckett robinduckett changed the title enhancement request: SNS FilterPolicy AND/OR ($and/$or) support enhancement request: SNS FilterPolicy extras support Mar 9, 2024
@bentsku bentsku self-assigned this Apr 3, 2024
@alexrashed alexrashed added type: feature New feature, or improvement to an existing feature and removed type: enhancement labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws:sns Amazon Simple Notification Service status: backlog Triaged but not yet being worked on type: feature New feature, or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants