Refactor sdk tests #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddnewton
force-pushed
the
refactor_sdk_tests
branch
from
6c12824
to
919cea2
Compare
| @@ -0,0 +1,50 @@ | |||
| module SdkSupport | |||
| class Tracker | |||
There was a problem hiding this comment.
are you venturing into stuff that rspec and mocks would do more easily
There was a problem hiding this comment.
Not really. I actually tried using minitest/mock and then mocha, but neither of them were able to do the stuff that I'm doing here as succinctly. It might be a product of poor design since I have the sdk abstracted so far away (stacks effectively call AwsShim.instance.shim.client.method). Not sure if that's a bug or a feature.
There was a problem hiding this comment.
i was thinking about: https://relishapp.com/rspec/rspec-mocks/docs/configuring-responses/returning-a-value#specify-different-return-values-for-multiple-calls, just reminded me of whats happening here.
|
|
kddnewton
added a commit
that referenced
this pull request
Jun 16, 2016
* refactor tests into simpler stubber procedure * add tests for create and wait * finish testing waiting behavior * move to sdk_support directory * bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also increase test coverage to 100%