Changesets #28
Merged
Changesets #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is more of a general question, but also relates to changesets. Should we do some logic around supporting really large templates? The limits specify that a template can be 51,200 bytes, but can be up to 460,800 if it's uploaded to S3. What do you think? |
|
I'd wait until we need that functionality to worry about it |
|
Agreed we haven't needed it yet, but I did use S3 when making changesets for the VPC updates, so it might become relevant again for us. It would also be a good feature to have when open sourcing. I don't think we need to worry about it here though. This could also be a minor version bump, if you want, since semver says: "MINOR version when you add functionality in a backwards-compatible manner" Either way, |
kddnewton
added a commit
that referenced
this pull request
Jun 16, 2016
* support creating changesets * bump version * fix style warnings * support deploying change sets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.