Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclipse-jarsigner-plugin causing problems with shaded jar #168

Closed
hmottestad opened this issue Dec 23, 2018 · 6 comments
Closed

eclipse-jarsigner-plugin causing problems with shaded jar #168

hmottestad opened this issue Dec 23, 2018 · 6 comments

Comments

@hmottestad
Copy link
Contributor

Hi,

I'm using RDF4J which uses your library deeper within. When I wrap everything in a shaded jar in the end I get a signature error.

I think it is because your jar is being signed with the eclipse jar signer plugin.

So far I know that bouncy castle signs their jars to make sure that the crypto content isn't modified.

Is there any such sensitive information in your jar files (eg. crypto implementations)?

Cheers,
Håvard

@dsmiley
Copy link
Contributor

dsmiley commented Dec 23, 2018

There is no sensitive information in the jar. Perhaps the shading process disturbs the content such that there's a signature error? Does this error occur for a particular file?

@hmottestad
Copy link
Contributor Author

It occurs when executing the jar. Shading does break any signatures. It kinda unpacks and repacks the jars.

@hmottestad
Copy link
Contributor Author

hmottestad commented Dec 25, 2018

Here is a repo I created to show the issues down the line: https://github.com/hmottestad/signature-problem

run.sh builds and runs everything (use java 8)

The Pom.xml file contains some comments for a workaround.

@hmottestad
Copy link
Contributor Author

Your JTS projected uses pgp signing instead. This signing doesn’t sign the jar as forcefully. Could you switch to that way of signing for this project too?

@hmottestad
Copy link
Contributor Author

And merry Christmas :)

@hmottestad
Copy link
Contributor Author

I§ve made a PR: #169

dsmiley pushed a commit that referenced this issue Dec 26, 2018
… that users that build/package this project can use fat jars without having to strip out signatures

Signed-off-by: Håvard Ottestad <hmottestad@gmail.com>
@dsmiley dsmiley closed this as completed Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants