Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JtsGeometry.unwrapDateline should call geom.geometryChanged on GeometryCollections #83

Closed
dsmiley opened this issue Jul 29, 2014 · 1 comment
Labels

Comments

@dsmiley
Copy link
Contributor

dsmiley commented Jul 29, 2014

The JtsGeometry constructor calls unwrapDateline(). If there are GeometryCollection (or subclasses) involved that has a geometry that crosses the dateline, the geom.geometryChanged() (which invalidates the envelope) is not called on the collection. The fix is to call it at the top level instead of at the component part level.

@sttawm
Copy link

sttawm commented Jul 29, 2014

It turns out that this change can cause a failure for direct instances (i.e. non-subclasses) of GeometryCollection, as they do not support the intersection() method, which may now be called in cutUnwrappedGeomInto360.

I've addressed this (and a few other things) in a fork, #84.

@dsmiley dsmiley removed their assignment Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants