Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offset of extracted references #69

Closed
lgalke opened this issue Oct 17, 2017 · 5 comments
Closed

Offset of extracted references #69

lgalke opened this issue Oct 17, 2017 · 5 comments
Labels
bug The issue reports a bug. testing urgent This issue has top priority.
Milestone
Workshop

Comments

@lgalke
Copy link
Member

lgalke commented Oct 17, 2017 •
edited

There is a problem with the offset of extracted references, as shown in the picture:
Assumed coordinates format here was x1 y1 x2 y2

locdb-screen
@lgalke lgalke added bug The issue reports a bug. reference extraction The issue needs to be addressed by the reference extraction component. urgent This issue has top priority. labels Oct 17, 2017
@lgalke lgalke added this to the Workshop milestone Oct 17, 2017
@lgalke
Copy link
Member Author

lgalke commented Oct 17, 2017

After different interpretation x1 x2 y1 y2 of the coordinates, it now looks as follows
locdb-fail2

@rtahseen
Copy link
Member

OCR component is returning coordinates in format x1 y1 x2 y2. If you closely look the first screenshot, you will realize that these coordinates are for references on right page only. This issue was already mentioned earlier and it is resolved in the new version. The offset is there due to cropping mechanism which is also resolved in the new version.

@lgalke
Copy link
Member Author

lgalke commented Oct 19, 2017

That's great! I'll give it another try in the afternoon and good that the format is exactly the one we assumed so far.

@lgalke
Copy link
Member Author

lgalke commented Oct 23, 2017

Will be fixed with the new ocr processing engine, same as #72 . One more test necessary before closing the issue.

@lgalke lgalke added testing and removed reference extraction The issue needs to be addressed by the reference extraction component. labels Oct 23, 2017
@lgalke
Copy link
Member Author

lgalke commented Oct 27, 2017

fixed by new ocr version

@lgalke lgalke closed this as completed Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue reports a bug. testing urgent This issue has top priority.
Projects
None yet
Milestone
Workshop
Development

No branches or pull requests
2 participants
@lgalke @rtahseen