Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with localization #48

Closed
dancodes opened this issue Feb 22, 2022 · 3 comments
Closed

Issues with localization #48

dancodes opened this issue Feb 22, 2022 · 3 comments

Comments

@dancodes
Copy link

Hello,

We've ran into a problem regarding the translation of fields in your extension.

The TCA model tx_html5videoplayer_domain_model_video contains relevant l10n_* fields indicating that it is translatable. However, its child element tx_html5videoplayer_video_content lacks them, yet its parent table is of type inline.

This is troublesome for us as we assume that all translatable high-level content should also have translatable child elements. We believe it's a reasonable design choice and would make your extension work out of the box with our translation module.

Would this be something you could consider updating?

@lochmueller
Copy link
Owner

Hey @dancodes
The extension is not actively maintained anymore. Feel free to send pull-request and I will review, merge and release them. But currently I cannot actively support any features/issues for this extension. Sorry.
Regards,
Tim

@dancodes
Copy link
Author

Hi @lochmueller

I will forward this to our team and we will decide what to do next.

I would like to thank you for your quick response and I fully understand the situation.

Have a nice day!

@lochmueller
Copy link
Owner

I will close this issue. Feel free to send PRs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants