Change pRojects to allow the use of the checkpoint package

[stephlocke]

When I first setup pRojects I put in a boolean flag for the use of packrat. Since then I'd been considering allowing checkpoint, especially as packrat can really get on my nerves!

This change amended the function inputs to have packagedeps not packrat as an argument and amended some code.

To avoid changing expected behaviours, the functions still use packrat by default.

[stephlocke]

Hey @jonmcalder, what do you think of this change? Do you think anything else needs doing on it?

[coveralls]

Coverage increased (+0.3%) to 49.198% when pulling 91cd32c on feature-checkpoint into 91ed1de on master.

[jonmcalder]

I approve! packrat is a rather heavy dependency and can be quite frustrating especially for newer useRs. I haven't actually tried checkpoint before but this change looks great.

I'll review in more detail this evening when I've got time.

[coveralls]

Coverage increased (+0.3%) to 49.198% when pulling 167a16c on feature-checkpoint into 91ed1de on master.

[jonmcalder]

createTrainingProject() needs to be updated, since it still includes:

# Installation dir
  usePackrat <- !methods::hasArg("packrat")
  if (!usePackrat)
    usePackrat <- list(...)[["packrat"]]
  installDir <- ifelse(usePackrat, name, .libPaths())

and then further on:

if (usePackrat) {
    packrat::snapshot(name)
    packrat::restore(name)
  }

This results in an error when trying to create a training project with the new gadget/template.

[jonmcalder]

I would:

a) shorten this label (e.g. just Reproducibility), since a long line messes up the alignment in the template UI
b) group it with the other dropdowns by positioning the check boxes to the right
c) the same applies (both label and alignment) to all the other templates

Before:

After:

Still looks pretty terrible, but slightly less terrible 😄

[coveralls]

Coverage decreased (-2.03%) to 46.875% when pulling 86163bf on feature-checkpoint into 91ed1de on master.

[stephlocke]

Thanks for the feedback!

Note in 1cf5ece I also improved arg (imo anyway ;) ) handling ...

• this removed methods as a dependency
• used an exported function from devtools instead of an internal function
• stops if slide/handout engines requested are not currently installed

[maelle]

@stephlocke silly question, should checkpoints be the default?

[stephlocke]

Sure, I think we can make "breaking" type changes like this, esp as this only does package setup

[stephlocke]

@maelle this was getting to the same error on master but I think the checkpoint code could help you fix things so I've now merged it in

[maelle]

Ok, will look next week probably. I think that #60 and also letting the function clean and say what was wrong will help, because clearly something went wrong inside createTrainingProject and the current code doesn't let me easily what.