Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JOSS] Add unit testing via CI #2

Closed
faroit opened this issue Jul 13, 2020 · 2 comments
Closed

[JOSS] Add unit testing via CI #2

faroit opened this issue Jul 13, 2020 · 2 comments

Comments

@faroit
Copy link
Contributor

faroit commented Jul 13, 2020

The package comes without automatic unit tests. Since the application is sonification, the only way to test the functionality of this package is to listen to the outputs. As this is hard to reproduce I would strongly encourage to include a few unit tests that produce tones give a short known x/y sequence.

This issue is part of a [https://github.com/openjournals/joss-reviews/issues/2446](JOSS submission review)
@faroit
Copy link
Contributor Author

faroit commented Jul 13, 2020

Update: I didn't saw the test folder being part of the main code folder. I suggest

  • moving the test folder to /tests
  • enable automatic unit testing either via travis, circle.ci or github actions

@faroit faroit changed the title [JOSS] Add unit testing [JOSS] Add unit testing via CI Jul 13, 2020
@lockepatton
Copy link
Owner

I've moved and connected the ./tests files to travis - and the passing badge is now in the README.md. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faroit @lockepatton