Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close unit-test milestone #41

Closed
wxmerkt opened this issue Nov 18, 2019 · 11 comments
Closed

Close unit-test milestone #41

wxmerkt opened this issue Nov 18, 2019 · 11 comments

Comments

@wxmerkt
Copy link
Collaborator

wxmerkt commented Nov 18, 2019

In GitLab by @nmansard on Nov 28, 2018, 09:52

The unit test list should be as follows:

  1. DDP converges in 1 step for LQR systems
  2. DDP and KKT for LQR matches
  3. num-diff versus algo diff
  4. stopping criteria unit test (tbf, possibly compare with KKT)
  5. regularization unit test (test that backward pass with regularization or with control cost is equal)
  6. regularization tuning test (tbf)

We may also want to add an integrative test with the arm (and later with legged robots), i.e. comparing the numerical results of the test with a reference execution.

Unit-test validation before merge-request, implemented by @nim65s should be active.

When all that points are matched, close the milestone unittest.

@wxmerkt
Copy link
Collaborator Author

wxmerkt commented Nov 18, 2019

In GitLab by @cmastalli on Dec 3, 2018, 13:35

changed the description

@wxmerkt
Copy link
Collaborator Author

wxmerkt commented Nov 18, 2019

In GitLab by @cmastalli on Dec 3, 2018, 13:36

For the moment, we have solved the point 1. @nmansard I need that you check a proposed solution for the point 4.

@wxmerkt
Copy link
Collaborator Author

wxmerkt commented Nov 18, 2019

In GitLab by @cmastalli on Dec 6, 2018, 17:47

mentioned in merge request !29

@wxmerkt
Copy link
Collaborator Author

wxmerkt commented Nov 18, 2019

In GitLab by @cmastalli on Dec 6, 2018, 22:54

@nmansard I am not sure if I understand the point 5. How is possible that the control cost is equals to the regularization?

For instance the control cost (0.5 * u^T * Q * u^T) has a gradient different to zero (i.e. Q * u), and often this isn't zero in the optimal solution neither. On the other hand, regularization scheme affects only Quu (mu * I), not Qu!.

@wxmerkt
Copy link
Collaborator Author

wxmerkt commented Nov 18, 2019

In GitLab by @nmansard on Dec 7, 2018, 09:43

Currently working:
1,2,4

@wxmerkt
Copy link
Collaborator Author

wxmerkt commented Nov 18, 2019

In GitLab by @cmastalli on Dec 7, 2018, 20:57

mentioned in merge request !31

@wxmerkt
Copy link
Collaborator Author

wxmerkt commented Nov 18, 2019

In GitLab by @cmastalli on Dec 7, 2018, 20:58

And now working 3.

@wxmerkt
Copy link
Collaborator Author

wxmerkt commented Nov 18, 2019

In GitLab by @cmastalli on Dec 11, 2018, 18:20

mentioned in merge request !32

@wxmerkt
Copy link
Collaborator Author

wxmerkt commented Nov 18, 2019

In GitLab by @cmastalli on Dec 11, 2018, 18:20

At the moment it's missing only the point 6.

@wxmerkt
Copy link
Collaborator Author

wxmerkt commented Nov 18, 2019

In GitLab by @nmansard on Jan 21, 2019, 15:27

Done.

@wxmerkt
Copy link
Collaborator Author

wxmerkt commented Nov 18, 2019

In GitLab by @nmansard on Jan 21, 2019, 15:27

closed

@wxmerkt wxmerkt closed this as completed Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant