Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migration] Enhance schema definition for diffToApply #244

Open
mdartic opened this issue Aug 11, 2023 · 0 comments
Open

[Migration] Enhance schema definition for diffToApply #244

mdartic opened this issue Aug 11, 2023 · 0 comments
Labels
Back-End Related to Backend development next Next version of LocoKit based on Feathers 5, Nuxt 3, ...

Comments

@mdartic
Copy link
Member

mdartic commented Aug 11, 2023

In migration.class.ts there is an issue when setting the diffToApply property of the migration.

There is a conflict between the schema for the creation of a migration (that don't have the diffToApply)
and the need of this property before injecting it in database.

https://github.com/locokit/locokit/pull/237/files/8712f5dd5454cadb1ff776dbd5b0ae47d0f17a7f#diff-825d9cd9bd27dceb54f741eed814e8488f513e1b54ffec28669de25838eb224cR440-R443

This issue is here to fix this issue, by better understanding how to use schemas & feathers.
There is surely sthg to do with external schema (the API contract, user don't have to give the diffToApply property)
versus internal schema, where diffToApply is required before injection.

@mdartic mdartic added Back-End Related to Backend development next Next version of LocoKit based on Feathers 5, Nuxt 3, ... labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back-End Related to Backend development next Next version of LocoKit based on Feathers 5, Nuxt 3, ...
Projects
Status: Triage
Development

No branches or pull requests

1 participant