Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PA Review: User Authentication #2

Closed
6 tasks done
locphan2207 opened this issue Jan 30, 2018 · 3 comments
Closed
6 tasks done

PA Review: User Authentication #2

locphan2207 opened this issue Jan 30, 2018 · 3 comments
Assignees

Comments

@locphan2207
Copy link
Owner

locphan2207 commented Jan 30, 2018

  • Backend: DB, model, controller, views
  • Redux Loop: ajax, actions, reducer
  • Presentational Components
  • Styling
  • Smooth, bug-free navigation
  • Adequate and appropriate seeds
@locphan2207
Copy link
Owner Author

Finished styling. I don't know how to do the demo login yet

@anastassia-b
Copy link
Collaborator

anastassia-b commented Jan 31, 2018

Nice, this is really well done, the styling is really responsive. A few comments:

  • Errors persist when I switch between forms. Please clearErrors() when the view changes.
  • Guest image is breaking. You could download and store it in your assets.
  • It would be nice if there was a way to access "Signup" within the Login form, and "Login" from the Signup form. As it is now, you have to click out of the modal and click the button again.
  • To add a demo account, you can make a "Demo" button which will login(demoUser) onClick, where demoUser is a guest user seeded in your database.

@anastassia-b
Copy link
Collaborator

Excellent work! Functionality is perfect and the styling is on point. This MVP is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants