Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PA Review: Recipes (Index and Show page) #4

Closed
12 tasks done
locphan2207 opened this issue Feb 1, 2018 · 2 comments
Closed
12 tasks done

PA Review: Recipes (Index and Show page) #4

locphan2207 opened this issue Feb 1, 2018 · 2 comments
Assignees
Milestone

Comments

@locphan2207
Copy link
Owner

locphan2207 commented Feb 1, 2018

  • Backend: DB, model, controller, views
  • Redux Loop: ajax, actions, reducer
  • Presentational Components
  • Styling
  • Smooth, bug-free navigation
  • Adequate and appropriate seedscipe Index page shows all recipes (Title, Total time and header image)

Others:

  • Small animation when hovering on Recipe Index Item
  • Canvas drawing for Cooking Time based on minute
  • Ingredient multiplying
  • Sticky Navbar switch when scrolling down
  • Section jumping by clicking on navigating buttons (Overview, Comments)
  • Suggestion Component
@locphan2207 locphan2207 added this to the Recipes milestone Feb 1, 2018
@locphan2207 locphan2207 changed the title PA PA Review: Recipes (Index and Show page) Feb 1, 2018
@anastassia-b
Copy link
Collaborator

anastassia-b commented Feb 2, 2018

Awesome work on this feature! I love the responsive ingredients list and the display of the baking times. The seed data is beautiful and the styling is impeccable. The recipe index page is complete, and you are finalizing the suggestion component on the recipe show page.

Based on our discussion today, here are some comments:

  • You could optionally user react-scroll to scroll to a precise location on the page and specify additional parameters.
  • Remove border-radius from the buttons to have a flat underline when active.
  • A quick fix for the nav-bar bunching up when the window resizes is to give it a min-width.

@locphan2207
Copy link
Owner Author

In order to make the navigating buttons scroll to the correct positions, I created empty <div> and put them at correct positions. With those elements, I can use them as "stop points" for the scrolling.
By calling .scrollIntoView() on them, the navigating buttons can now bring users to correct positions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants