Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PA Review: Recipe Search #7

Closed
5 tasks done
locphan2207 opened this issue Feb 5, 2018 · 2 comments
Closed
5 tasks done

PA Review: Recipe Search #7

locphan2207 opened this issue Feb 5, 2018 · 2 comments
Assignees
@anastassia-b
Labels
core feature
Milestone
Recipe Search

Comments

@locphan2207
Copy link
Owner

locphan2207 commented Feb 5, 2018 •
edited

  • Backend: DB, model, controller, views
  • Redux Loop: ajax, actions, reducer
  • Presentational Components
  • Styling
  • Smooth, bug-free navigation

Others:
@locphan2207 locphan2207 added this to the Recipe Search milestone Feb 5, 2018
@locphan2207
Copy link
Owner Author

locphan2207 commented Feb 6, 2018 •
edited

Added searchResult slice to state shape
The original site does live search, but I think if I do that, it will be communicating with the server backend a lot, which causes bad performance. So, I don't do live search. Users have to click search button to submit the search action.

@locphan2207 locphan2207 reopened this Feb 7, 2018
@anastassia-b
Copy link
Collaborator

Live recipe search works well! If you have time later to change the titles of recipes so there is a larger search space, that would be good. Now, all of them are roughly called "Testing recipe x with author x", so the results are more sparse.

This MVP is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anastassia-b anastassia-b

Labels
core feature
Projects
None yet
Milestone
Recipe Search
Development

No branches or pull requests
2 participants
@locphan2207 @anastassia-b