Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-sided hypothesis test for c_A? #7

Closed
danielzuegner opened this issue May 18, 2020 · 2 comments
Closed

One-sided hypothesis test for c_A? #7

danielzuegner opened this issue May 18, 2020 · 2 comments

Comments

@danielzuegner
Copy link

Hi,

I have a question about the following section of the Code:

if binom_test(count1, count1 + count2, p=0.5) > alpha:
            return Smooth.ABSTAIN

According to the docstring of binom_test, by default it performs a two-sided hypothesis test. But to me it seems that we're only interested in a one-sided hypothesis test (i.e. calling binom_test with alternative='greater') with the alternative hypothesis that p>0.5, and abstain if the null hypothesis p=0.5 cannot be rejected. Alternatively, we could compare the result of binom_test with 2*alpha.

Could this be the case or am I missing something?

Thanks!

@jmcohen
Copy link
Collaborator

jmcohen commented May 18, 2020

This paper https://arxiv.org/abs/1610.03944 proves that the two-sided test gives the right result.

@danielzuegner
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants