Required formatting changes for the latest version of ROS 2 Rolling #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-m159
approved these changes
Apr 28, 2024
ayrton04
approved these changes
Apr 29, 2024
|
The Locus build server does not like the new ROS 2 Rolling formatting rules. One of these days I'll look into a solution for that. And into why the upsteam CI tests are not running. But today is not that day. |
|
The upstream CI build tests failed, but we are down to only two failures. This is fine because the next PR #369 should fix those remaining test failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required formatting changes for the latest version of ROS 2 Rolling. The formatting rules seem to be something of a moving target. This reverts most of but not all of the formatting changes I added to the last PR. Now that there is a Jazzy build happening, I'm hoping this settles down.