[RST-1960] Added a tangent/parameter space flag to the covariance function #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DLu
approved these changes
Apr 29, 2019
ayrton04
approved these changes
May 8, 2019
fuse_graphs/src/hash_graph.cpp
Outdated
| { | ||
| for (size_t i = 0; i < covariance_requests.size(); ++i) | ||
| { | ||
| if (!covariance.GetCovarianceBlockInTangentSpace(all_covariance_blocks.at(i).first, |
There was a problem hiding this comment.
Nit: maybe make const references to these to avoid the repeated indexing? Same for the other variables below.
svwilliams
force-pushed
the
RST-1960-tangent-space-cov
branch
from
5220048
to
33946ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a tangent/parameter space flag to the covariance function.