Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RST-1548] transform covariance #2

Merged
merged 5 commits into from
Dec 3, 2018
Merged

Conversation

svwilliams
Copy link
Contributor

Added methods to:

  • Get Eigen Matrices from the tf2_2d objects
  • Stream tf2_2d objects in a human-readable format
  • Convert tf2_2d objects to a wider array of ROS message types
  • (finally) Transform a 3x3 covariance matrix using a tf2_2d transform object

I'm open to adding any additional function signatures that may be helpful for anyone. In particular, if there is a covariance datatype that is useful and not currently in the list of supported types.

Copy link
Contributor

@ayrton04 ayrton04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many handy methods!

/**
* @brief Stream the rotation in human-readable format
*/
std::ostream& operator<< (std::ostream& stream, const Rotation& rotation);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space after the operator intentional? I'm guessing this is one of those annoying parsing issues for the compiler.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a "copy and paste from the internet" issue. Will fix.

@svwilliams svwilliams requested a review from DLu November 28, 2018 22:16
@svwilliams svwilliams merged commit 2cad10a into devel Dec 3, 2018
@svwilliams svwilliams deleted the RST-1548-transform-covariance branch December 3, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants