Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI of Sorting Columns #2466

Closed
2 tasks done
andrewbaldwin44 opened this issue Nov 14, 2023 · 9 comments
Closed
2 tasks done

Improve UI of Sorting Columns #2466

andrewbaldwin44 opened this issue Nov 14, 2023 · 9 comments

Comments

@andrewbaldwin44
Copy link
Collaborator

Prerequisites

Description

I realized (a little bit late) that MUI has a TableSortLabel component that we could leverage to improve the UI when sorting the columns in the different tables.
image
The improvement would display arrows, indicating not only which column is being sorted, but also whether the sort is in reverse or not.

The one trade-off is that with the addition of these arrows in the column head, we will never have enough room that the text in the head doesn't wrap (the # Requests / # Fails always wraps)

@cyberw
Copy link
Collaborator

cyberw commented Nov 14, 2023

Perhaps we can use our old friend non-breaking space ( ) for the #-columns?

@andrewbaldwin44
Copy link
Collaborator Author

Yes you can of course, but then you get our old friend vertical scrollbar 😂

@cyberw
Copy link
Collaborator

cyberw commented Nov 14, 2023

Well that sucks... I dont really have any other ideas... I dont think sorting is used very often so it is not top prio...

@andrewbaldwin44
Copy link
Collaborator Author

andrewbaldwin44 commented Nov 14, 2023

Found a bit of a workaround, the scrollbar disappears >= 1388px
image

@cyberw
Copy link
Collaborator

cyberw commented Nov 14, 2023

Perhaps we could use "dense padding" to further compress it? I'm not a fan of 3-row headers :P

@andrewbaldwin44
Copy link
Collaborator Author

Yeah but the "small" table only changes the padding between rows, not between columns :/
image

@cyberw
Copy link
Collaborator

cyberw commented Nov 14, 2023

Huh... annoying... sorry, I dont have any ideas...

@andrewbaldwin44
Copy link
Collaborator Author

This is one reason I'm not the biggest fan of MUI, it can really limit you in terms of customization :/ I tried "hacking" the padding as well, but then the alignment for the whole table becomes messed up
image
Might be best to just leave it as it for now

@cyberw
Copy link
Collaborator

cyberw commented Nov 14, 2023

Yea that is probably best for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants