Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest.json file is needed for add to home screen #73

Closed
gokulkrishh opened this issue Sep 11, 2016 · 3 comments
Closed

Manifest.json file is needed for add to home screen #73

gokulkrishh opened this issue Sep 11, 2016 · 3 comments
Labels
enhancement

Comments

@gokulkrishh
Copy link

Why ?

Site and document is updated with offline support is great. But no manifest.json file is present to add lodash to home screen.
@gokulkrishh gokulkrishh changed the title Manifest.json file is not there Manifest.json file is need for Add to home screen icon Sep 11, 2016
@gokulkrishh gokulkrishh changed the title Manifest.json file is need for Add to home screen icon Manifest.json file is needed for add to home screen Sep 11, 2016
@jdalton
Copy link
Member

jdalton commented Sep 11, 2016

Hi @gokulkrishh!

Would you like to create a PR to add it?

@gokulkrishh
Copy link
Author

@jdalton Yep I have already forked and added the icons + manifest. Testing it locally. Will push a PR once done 👍

@gokulkrishh gokulkrishh mentioned this issue Sep 11, 2016
Closed
@jdalton
Copy link
Member

jdalton commented Sep 11, 2016

Moved to #74.

@jdalton jdalton closed this as completed Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added manifest.json and icons gokulkrishh/lodash.github.io
2 participants
@jdalton @gokulkrishh