Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forEach is not a function error in some browsers #2924

Closed
hyperknot opened this issue Jan 11, 2017 · 1 comment
Closed

forEach is not a function error in some browsers #2924

hyperknot opened this issue Jan 11, 2017 · 1 comment
Labels

Comments

@hyperknot
Copy link

hyperknot commented Jan 11, 2017

I am getting Sentry errors from a small subset of users telling me that there is a problem:
TypeError: n.forEach is not a function when loading lodash (n is from minifying).

The user agent strings of the browsers are the following:

Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; WOW64; Trident/7.0)
Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (Windows NT 6.1; rv:18.0) Gecko/20100101 Firefox/18.0

Now it seems like Firefoxes are really old as well as IE is some weird version or compatibility mode, so I'm totally OK to just have these browsers brake.

I've opened this ticket for the following reasons:

  1. It might be useful for you to know that n.forEach is breaking on some browsers.
  2. Ask what minimum IE and Firefox versions can I safely say are compatible with lodash? Readme says IE11+ but tests are run on IE9+. So which one?

Lodash is 4.x latest.

@jdalton
Copy link
Member

jdalton commented Jan 11, 2017

Hi @hyperknot!

What you're seeing is probably related to the forEach method of a Map or Set. This was known to be buggy in ancient and unsupported versions of Firefox and buggy experimental flags of EOL Node versions. As for the IE fail I think that could be related to a bad shim as we support IE10 and test on IE10 without issue.

We have SauceLabs configured to test these browsers.

@jdalton jdalton closed this as completed Jan 11, 2017
@lodash lodash deleted a comment from FelixSchwarz Dec 12, 2017
@lodash lodash locked and limited conversation to collaborators Dec 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants