Fix typo in escapeRegExp

[younesfkihi]

No description provided.

[jdalton]

Thank you @younesfkihi !

[falsyvalues]

@jdalton I don't think this is correct \\ is an escape for \ character and we match against \ not \\.

[jdalton]

@falsyvalues
The typo is that you can't write "\" in JS, because it's escaping the ".
So to make it more JS-y, they wanted it written as "\\".

[falsyvalues]

@jdalton Still if you think about how regex work (and it is about regex) it's misleading and it's a comment which will be published on docs site. Anyway its up to you, just my few 💵 😄

[younesfkihi]

@falsyvalues @jdalton I added the fix because the docs site shows "$", "", "." instead of "$", "\", ".". How can "\" be shown on the site without escaping \?

[jdalton]

@falsyvalues Ah okay, I see your point. If you'd like to revert that's cool.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.