Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set/unset per method package is using memoize, not memoizeCapped as in lodash proper #3793

Closed
justinbarry opened this issue May 17, 2018 · 3 comments
Labels

Comments

@justinbarry
Copy link

We discovered an unbounded usage of memory recently while using the per method packages.

Demonstrated here: https://github.com/justinbarry/lodash-mem-leak-example

Individual unset package

var stringToPath = memoize(function(string) {

Individual set package

var stringToPath = memoize(function(string) {

In lodash proper:

const stringToPath = memoizeCapped((string) => {

@jdalton
Copy link
Member

jdalton commented May 17, 2018

Hi @justinbarry!

The per method packages are soft deprecated. For the most up-to-date v4 you should stick with the primary lodash package and cherry-pick your methods lodash/unset.

@jdalton jdalton closed this as completed May 17, 2018
@justinbarry
Copy link
Author

@jdalton is that information documented anywhere? If not, could I help with that?

@lock
Copy link

lock bot commented May 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants