Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lodash build and unit tests work when used as a node package. #40

Closed
jdalton opened this issue Jun 29, 2012 · 2 comments
Closed

Make lodash build and unit tests work when used as a node package. #40

jdalton opened this issue Jun 29, 2012 · 2 comments

Comments

@jdalton
Copy link
Member

jdalton commented Jun 29, 2012

Make lodash build and unit tests work when used as a node package.
This means using the package.json dependencies property and removing the use of submodules.

I've already added a scripts entry to the package.json and prepped the build script to use process.cwd().

// cc @strk @iammerrick

@strk
Copy link

strk commented Jun 29, 2012

On Fri, Jun 29, 2012 at 09:25:39AM -0700, John-David Dalton wrote:

Make lodash build and unit tests work when used as a node package.
This means using the package.json dependencies property and removing the use of submodules.

I've already added a scripts entry to the package.json and prepped the build script to use process.cwd().

// cc @strk @iammerrick

Dunno why you're cc'ing me, but yeah, I'm happing with seeing unit tests added
to all of node components :)

Even happier if they can be run with a "make check".

--strk;

@jdalton jdalton closed this as completed in 637a6e1 Jul 9, 2012
jdalton added a commit that referenced this issue Sep 25, 2014
Former-commit-id: 80165ec342e8b833a28bbe66f59e074c8f4f5185
@lock
Copy link

lock bot commented Jan 21, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants