Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Words method uses punctuation emojis as a separator #5758

Open
eabrakov opened this issue Oct 24, 2023 · 0 comments
Open

Words method uses punctuation emojis as a separator #5758

eabrakov opened this issue Oct 24, 2023 · 0 comments

Comments

@eabrakov
Copy link

For the case string has some unicode symbols the src/.internal/unicodeWords.ts counts all punctuation symbols as separator, even if it followed by \ufe0f for example, which could be used as an indication of emoji, but not punctuation

So

words('abc!def') // ['abc', 'def'] as expected
words('abc\u203c\ufe0fdefdef') // actual ['abc', 'def'], expected ['abc', '\u203c\ufe0f', 'def'], same as other emojis

Please let me know if you have no concerns about expected result, so I could create a PR with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant