Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kastaldi #43

Closed
wants to merge 2 commits into from
Closed

Kastaldi #43

wants to merge 2 commits into from

Conversation

kastaldi
Copy link

@kastaldi kastaldi commented Mar 1, 2022

I have a custom contextmenu that doesn't work anymore that doesn't work anymore when I use the timepicker plugin.
I added "contextmenu" setting, true or false. Default is false. if true you can call contextmenu right clicking the box. If false, timepicker is shown when you click right mouse button. You can use it when you have a custom context menu . I also modified the index.html ".standard" input to show you how it works. Hope I didn't break anything because it is the first time I use github with vscode.

@loebi-ch
Copy link
Owner

loebi-ch commented Mar 1, 2022

Sorry, the real js diff isn't so large. I just added "contextmenu:false" to settings and modified two functions, onInputElementDragSelectContextMenu and onInputElementMouseDown.

I've been just wondering why the diff looks so strange... Hard to find where you made some changes...

@kastaldi
Copy link
Author

kastaldi commented Mar 1, 2022

I'll try to sort this mess. :(

@loebi-ch
Copy link
Owner

loebi-ch commented Mar 1, 2022

I'll try to sort this mess. :(

It's okay, you don't have to do anything. Thanx to your info about the changes, I was able to find them.

Just give me some more minutes and I will release a new version with your valuable input. I really appreciate that!

@kastaldi
Copy link
Author

kastaldi commented Mar 1, 2022

Thanks!

@loebi-ch
Copy link
Owner

loebi-ch commented Mar 1, 2022

You'll find new configuration option contextmenu in version 2.6.2.

@loebi-ch loebi-ch closed this Mar 1, 2022
@kastaldi kastaldi deleted the kastaldi branch March 1, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants