Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment rollback (at least for Helm) #1239

Closed
iSeiryu opened this issue Dec 3, 2020 · 3 comments
Closed

Deployment rollback (at least for Helm) #1239

iSeiryu opened this issue Dec 3, 2020 · 3 comments
Assignees
Labels
area/chart-deployment Issues related to the deployment of charts with helm kind/feature New feature or feature request

Comments

@iSeiryu
Copy link
Contributor

iSeiryu commented Dec 3, 2020

Is your feature request related to a problem?
kinda

Which solution do you suggest?
It would be a great feature if devspace could deploy an image, wait for it to start, check readiness probe and rollback in case of a failure and report about it somehow so the CI/CD pipeline would crash and output some meaningful info.
Adding an ability to execute a script when this happens would be a nice touch too.

Which alternative solutions exist?
Adding --wait to a deployment and manually detecting when a deployment crashes and invoking one of these commands:

helm rollback my-api <revision>
kubectl rollout undo deployment.v1.apps/my-api-deployment --to-revision=<revision>

But before running those commands I'd need to do some queries to know the deployment names and the previous revision number. It requires a lot of additional scripts that someone would have to maintain.

/kind feature

@iSeiryu
Copy link
Contributor Author

iSeiryu commented Dec 3, 2020

Tools like Vamp and Garden are capable of doing a rollback: https://docs.garden.io/using-garden/workflows#how-it-works.
Garden has onError event. Maybe devspace could add onError hooks too?
https://learnk8s.io/kubernetes-rollbacks

@iSeiryu iSeiryu closed this as completed Dec 6, 2020
@iSeiryu iSeiryu reopened this Dec 6, 2020
@FabianKramm
Copy link
Collaborator

@iSeiryu thanks for opening this issue! Yes, I think an event like onError is actually a good idea. I'll add this as a feature

@FabianKramm FabianKramm added area/chart-deployment Issues related to the deployment of charts with helm kind/feature New feature or feature request labels Dec 7, 2020
@FabianKramm FabianKramm self-assigned this Dec 8, 2020
@FabianKramm FabianKramm removed their assignment Sep 21, 2022
@deniseschannon
Copy link

Closing due to inactivity and the version used. If you are still facing this issue with our latest DevSpace version, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chart-deployment Issues related to the deployment of charts with helm kind/feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

4 participants