Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ".devspace/" entry into ".dockerignore" on "devspace init" #1371

Closed
epierotto opened this issue Mar 26, 2021 · 2 comments
Closed

Add ".devspace/" entry into ".dockerignore" on "devspace init" #1371

epierotto opened this issue Mar 26, 2021 · 2 comments
Assignees
Labels
area/config Issues related to the config area/init Related to "devspace init" kind/enhancement Enhancement of an existing feature / improvement

Comments

@epierotto
Copy link

What happened?
devspace init does not add .devspace/ entry into .dockerignore

What did you expect to happen instead?
I expect devspace to add .devspace/ entry into .dockerignore since it's not required during image build.

How can we reproduce the bug? (as minimally and precisely as possible)
Run devspace init in a folder with both .gitignore and .dockerignore files and check the entries added by devspace.

Local Environment:

  • DevSpace Version: 5.9.1
  • Operating System: mac (Not sure is relevant)
  • Deployment method: N/A

Anything else we need to know?

/kind bug

@FabianKramm
Copy link
Collaborator

@epierotto thanks for creating this issue! Yes we should add this

@FabianKramm FabianKramm added area/config Issues related to the config area/init Related to "devspace init" kind/enhancement Enhancement of an existing feature / improvement labels Mar 29, 2021
@FabianKramm FabianKramm self-assigned this Mar 30, 2021
@FabianKramm
Copy link
Collaborator

@epierotto this was added with v5.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues related to the config area/init Related to "devspace init" kind/enhancement Enhancement of an existing feature / improvement
Projects
None yet
Development

No branches or pull requests

2 participants