Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevSpace prompts user for var provided by plugin #1857

Closed
JamesHutchisonCarta opened this issue Jan 12, 2022 · 2 comments
Closed

DevSpace prompts user for var provided by plugin #1857

JamesHutchisonCarta opened this issue Jan 12, 2022 · 2 comments
Labels
area/config Issues related to the config kind/bug Something isn't working

Comments

@JamesHutchisonCarta
Copy link

JamesHutchisonCarta commented Jan 12, 2022

What happened?
DevSpace prompts the user for a variable that is provided by a plugin. After the user enters a value, it is ignored and the value provided by the plugin is used instead.

? Please enter a value for OPEN_COMMAND (<nil>) 

This only happens when the variable in question is missing from generated.yaml, so typically this happens only once.

What did you expect to happen instead?
DevSpace does not prompt the user for a variable provided by a plugin.

How can we reproduce the bug? (as minimally and precisely as possible)

Create a plugin that outputs a value in stdout.

vars:
  - name: OPEN_COMMAND
    baseArgs:
      - get_open

And of course, add it with devspace add plugin ...

My devspace.yaml:

version: v1beta11
...

commands:
  - name: open_url
    command: "${OPEN_COMMAND} 'https:...some url"

Local Environment:

  • DevSpace Version: 5.18.1
  • Operating System: mac
  • ARCH of the OS: AMD64

/kind bug

@FabianKramm
Copy link
Collaborator

@JamesHutchisonCarta thanks a lot for creating this issue! Yes seems like the variable is not retrieved correctly from the plugin and instead treated as a regular variable. We should be able to fix this for the next release.

@FabianKramm FabianKramm added area/config Issues related to the config kind/bug Something isn't working labels Jan 13, 2022
pratikjagrut added a commit to pratikjagrut/devspace that referenced this issue Jan 18, 2022
FabianKramm added a commit that referenced this issue Jan 20, 2022
@JamesHutchisonCarta
Copy link
Author

Issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues related to the config kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants