Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't open a shell into the container until everything is synced (initially) #343

Closed
KaelBaldwin opened this issue Oct 31, 2018 · 4 comments
Assignees
Labels
area/config Issues related to the config area/sync Issues related to the real-time code synchronization area/terminal Issues related to the terminal proxy kind/feature New feature or feature request

Comments

@KaelBaldwin
Copy link

Is your feature request related to a problem?
No

Which solution do you suggest?

A configuration option to block opening the shell into the container until the sync process is initially caught up.

Which alternative solutions exist?

Additional context

My project can be rather large, especially if syncing all the dependencies.
I could exclude the dependencies from syncing, but overall it saves time to go ahead and let them sync.

However, if a developer gets into the project they can't really tell when everything is synced up without looking at the sync.log file. This might lead them to go ahead run the command to install all the dependencies themselves, or other commands that won't work correctly until everything is synced.

/kind feature

@LukasGentele
Copy link
Contributor

That might be a good idea to have that as a config option. Thanks for suggesting it. I would suggest an output like:

Initial code sync in progress (Xs) - Press ENTER to run sync in background and open terminal directly

That would allow users to skip the initial sync even if the config specifies the wait option. What is your opinion on this?

@FabianKramm: I think this option should not be specified in every sync path but rather in one central place to make it easier to use. Would devspace.terminal.waitOnInitialSync: true|false be a suitable config option?

@LukasGentele LukasGentele added kind/feature New feature or feature request priority/backlog area/sync Issues related to the real-time code synchronization area/terminal Issues related to the terminal proxy area/config Issues related to the config labels Oct 31, 2018
@KaelBaldwin
Copy link
Author

@LukasGentele Sorry, I see that I missed responding to your question. Yes I think that would be an excellent solution.

@LukasGentele
Copy link
Contributor

Awesome. I think @FabianKramm will work on this within the next few days.

FabianKramm added a commit that referenced this issue Apr 25, 2019
@KaelBaldwin
Copy link
Author

woohoo! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues related to the config area/sync Issues related to the real-time code synchronization area/terminal Issues related to the terminal proxy kind/feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

3 participants