Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide feature that causes image rebuilding and deployment when files specified in configuration change. #389

Closed
ALCarden opened this issue Nov 21, 2018 · 4 comments
Assignees
Labels
area/chart-deployment Issues related to the deployment of charts with helm area/dev Issues related to devspace dev kind/feature New feature or feature request

Comments

@ALCarden
Copy link
Contributor

Is your feature request related to a problem?
Currently our development stack is nodejs based, when we change our package.json it gets synced but the changes are not applied because npm install is not re-run in the container.

We can (and do disable) the sync of package.json but we to do delete the generated.yaml to force a rebuild of the image which contains the npm install run task.

Which solution do you suggest?
Have a new image configuration section consisting of an array of file globs which on change cause the docker file to be rebuilt, the tag to be updated and the configuration to be redeployed.

or

When specific file changes are detected for sync provide a property where we can specify a script to run in the container, e.g. to cause the application running in the container to take some action (development purposes only)

Which alternative solutions exist?
Manual: Remove the generated.yaml

Additional context

/kind feature

@LukasGentele LukasGentele added kind/feature New feature or feature request priority/backlog area/chart-deployment Issues related to the deployment of charts with helm area/dev Issues related to devspace dev labels Nov 21, 2018
@FabianKramm FabianKramm self-assigned this Nov 22, 2018
@FabianKramm
Copy link
Collaborator

@ALCarden I implemented this feature and added a new config option (your first suggestion) to the config under devspace.autoReload.paths where you can specify paths that devspace will watch. On changes to those globs devspace will rebuild and redeploy.

I also added a new example that shows how to use this feature (example reload-instead-of-sync)

FabianKramm added a commit that referenced this issue Nov 28, 2018
@FabianKramm
Copy link
Collaborator

Available in 2.4.0

@geoidesic
Copy link

The example is a dead link

@FabianKramm
Copy link
Collaborator

@geoidesic Yes sorry the example was renamed to redeploy-instead-of-hot-reload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chart-deployment Issues related to the deployment of charts with helm area/dev Issues related to devspace dev kind/feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

4 participants