Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make rebuild behavior configurable #733

Closed
FabianKramm opened this issue Oct 8, 2019 · 2 comments
Closed

build: make rebuild behavior configurable #733

FabianKramm opened this issue Oct 8, 2019 · 2 comments
Labels
area/building-images Issues related to building Docker images area/config Issues related to the config area/sync Issues related to the real-time code synchronization

Comments

@FabianKramm
Copy link
Collaborator

Currently the behavior for rebuilding images is different for devspace dev and devspace deploy: during devspace dev an image is not rebuild if a file in the context of the image has been changed, while during devspace deploy the image will be rebuild. However, there are cases when you want to rebuild an image during devspace dev e.g. when you are not syncing any files into that image.

Hence it makes sense to always rebuild images on context change during devspace dev for images that have not a sync path defined.

@FabianKramm FabianKramm added area/building-images Issues related to building Docker images area/config Issues related to the config area/sync Issues related to the real-time code synchronization labels Oct 8, 2019
@LukasGentele
Copy link
Contributor

Makes sense to me. However, checking for sync paths might be difficult because some users have just one image and use different entrypoints for different deployments. That means their sync paths cannot use the imageName option. Checking for this option might be inflexible for use cases like this one where users mainly use labelSelector instead of imageName.

FabianKramm added a commit that referenced this issue Oct 10, 2019
@LukasGentele
Copy link
Contributor

The implementation via #740 looks good. Making imageSelector and labelSelector non-exclusive and rather using them jointly for selecting pods solves the issue with using the same image in multiple deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/building-images Issues related to building Docker images area/config Issues related to the config area/sync Issues related to the real-time code synchronization
Projects
None yet
Development

No branches or pull requests

2 participants