-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local registry #2326
Merged
Merged
Local registry #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizardruss
force-pushed
the
local-repository
branch
8 times, most recently
from
September 23, 2022 14:42
033cdd6
to
40b0a62
Compare
lizardruss
requested review from
FabianKramm and
LukasGentele
as code owners
September 29, 2022 00:14
FabianKramm
requested changes
Sep 29, 2022
lizardruss
force-pushed
the
local-repository
branch
from
September 29, 2022 21:42
d610eb1
to
65c6346
Compare
lizardruss
commented
Oct 12, 2022
FabianKramm
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>
if possible)Adds a local image registry when user lacks push permissions to the remote registry.
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace ...
What else do we need to know?
TODO
ShouldRebuild()
to account for local registry usage${runtime.images.my-image.image}
&&${runtime.images.my-image}
image(name)
devspace init
doesn't produce config for local-registry (even in comments).devspace build
on minikube with default config(no config for local-registry) spins the registry pod doesn't push the image to it anddevspace build
command errors out. (Note: updated to skip push fordevspace build
and minikube, as well as skip local registry for minikube)devspace cleanup local-registry
command asks question (sure to cleanup) even when there is no registry pod running.