Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local registry #2326

Merged
merged 41 commits into from
Oct 19, 2022
Merged

Local registry #2326

merged 41 commits into from
Oct 19, 2022

Conversation

lizardruss
Copy link
Collaborator

@lizardruss lizardruss commented Sep 20, 2022

What issue type does this pull request address? (keep at least one, remove the others)
/kind feature

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
Adds a local image registry when user lacks push permissions to the remote registry.

Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace ...

What else do we need to know?

TODO

  • Detect push permissions
  • Deploy registry
  • Wait for Registry to be ready
  • Start port forwarding
  • Rewrite image tag for deployed registry
  • Build / Push image
  • Update runtime variables
  • Update config substitution
  • Update ShouldRebuild() to account for local registry usage
  • Acceptance Tests:
    • get_image output
    • ${runtime.images.my-image.image} && ${runtime.images.my-image}
    • image(name)
    • kubectl deployment rewritten
    • helm deployment rewritten
    • dev.*.imageSelector (and all the other different runtime rewritten config sections)
    • dev.*.devImage
  • Move local registry configuration to top level (avoid duplicating for multiple images)
  • Add progress indicator when transferring images
  • devspace init doesn't produce config for local-registry (even in comments).
  • devspace build on minikube with default config(no config for local-registry) spins the registry pod doesn't push the image to it and devspace build command errors out. (Note: updated to skip push for devspace build and minikube, as well as skip local registry for minikube)
  • devspace cleanup local-registry command asks question (sure to cleanup) even when there is no registry pod running.
  • logs need formatting

@lizardruss lizardruss changed the title Local repository Local registry Sep 20, 2022
@lizardruss lizardruss force-pushed the local-repository branch 8 times, most recently from 033cdd6 to 40b0a62 Compare September 23, 2022 14:42
@lizardruss lizardruss marked this pull request as ready for review September 29, 2022 00:14
pkg/devspace/build/registry/local_registry.go Outdated Show resolved Hide resolved
pkg/devspace/build/registry/local_registry.go Outdated Show resolved Hide resolved
pkg/devspace/build/registry/local_registry.go Outdated Show resolved Hide resolved
pkg/devspace/config/versions/latest/schema.go Outdated Show resolved Hide resolved
@FabianKramm FabianKramm merged commit 04c2339 into devspace-sh:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants