Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove incorrect statement about BuildKit deployment name #2413

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

lizardruss
Copy link
Collaborator

What issue type does this pull request address? (keep at least one, remove the others)
/kind documentation

What does this pull request do? Which issues does it resolve?
A user was attempting to manage the BuildKit Daemon using instructions from this repo in order to increase replicas and use a Horizontal Pod Autoscaler. However, the buildctl command is not supported by DevSpace, and our docs were misleading in that the Deployment created for the BuildKit Daemon would match the name given in the inCluster.name option.

Instead, this name is passed to docker buildx create --driver kubernetes which creates a deployment with a different name, usually ${inCluster.name}0. There is not an option to directly control the deployment name.

Please provide a short message that should be published in the DevSpace release notes
Fixed misleading documentation about BuildKit Daemon deployments

What else do we need to know?
Recommended that the user create the builder with docker buildx create --driver kubernetes --bootstrap and use the generated manifests as a starting point for their customizations.

@FabianKramm FabianKramm merged commit 5b0448e into devspace-sh:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants