Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building in Kaniko is broken from Windows in devspace 6+ #2423

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

lizardruss
Copy link
Collaborator

@lizardruss lizardruss commented Nov 15, 2022

What issue type does this pull request address?
/kind bugfix

What does this pull request do? Which issues does it resolve?
resolves #2412
fixes ENG-606

Please provide a short message that should be published in the DevSpace release notes
Fixed issues where DevSpace would:

  • force local registry with kaniko builds, even if --no-push is used
  • use the wrong path delimiters in windows
  • fail to skip local registry for loft vclusters on local kubernetes

@lizardruss lizardruss changed the title wip: refactor for kaniko builds Building in Kaniko is broken from Windows in devspace 6+ Nov 15, 2022
@lizardruss lizardruss marked this pull request as ready for review November 15, 2022 08:12
Copy link
Collaborator

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizardruss thanks for the PR! LGTM!

@FabianKramm FabianKramm merged commit 4be3908 into devspace-sh:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building in Kaniko is broken from Windows in devspace 6+
2 participants