Add kubectl client auth plugins #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianKramm
requested changes
Nov 11, 2019
There was a problem hiding this comment.
@mgruener thanks for opening this pull request! Looks good to me, however since you created this pull request we updated our kubernetes & helm version.
Could you merge the current devspace master into your branch and reexecute go mod vendor to be sure we have the correct dependencies needed for the 1.16.2 kubernetes version?
mgruener
force-pushed
the
kubectl-auth-plugins
branch
from
901ce7d
to
5491ddd
Compare
|
@FabianKramm done 🙂 |
FabianKramm
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address?
/kind enhancement
What is this pull request for? Which issues does it resolve?
Adds support for the different kubectl auth-provider plugins (for example OIDC). Without the plugins devspace fails with the following error during deployments (and other operations that require kubernetes access):
[fatal] Unable to create new kubectl client: new client: No Auth Provider found for name "XXX"This PR fixes this problem, as suggested by kubernetes/kops#5513
Does this pull request has user-facing changes?
No
Does this pull request add new dependencies?
Yes, should be visible in the diff.
What else do we need to know?
The actual code change is only the added import in pkg/devspace/kubectl/client.go.