Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise queue task abandonment #1867

Open
joachimmetz opened this issue May 2, 2018 · 2 comments
Open

Revise queue task abandonment #1867

joachimmetz opened this issue May 2, 2018 · 2 comments
Labels
core Issues relating to Plaso's core - processing, file access etc. enhancement New or improved functionality

Comments

@joachimmetz
Copy link
Member

When queued tasks are abandoned they are only abandoned in the task manager, they are still on the task queue. This can result in the task being processed and retried while the task manager considers this abandoned.

  • determine why the abandonment of queued tasks was necessary
  • revisit if abandonment of queue tasks is the appropriate strategy
@joachimmetz joachimmetz added enhancement New or improved functionality core Issues relating to Plaso's core - processing, file access etc. labels May 2, 2018
@joachimmetz
Copy link
Member Author

@Onager from the top of your head do you recall why the abandonment of queued tasks was necessary?

@Onager
Copy link
Contributor

Onager commented May 3, 2018

It was to ensure that processing actually stopped, for the case when a worker received a task, then immediately crashed. If the main process never gets an update to from the worker, it'll wait forever for the "queued" task to be completed.

@joachimmetz joachimmetz added this to To do in Task processing May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues relating to Plaso's core - processing, file access etc. enhancement New or improved functionality
Projects
Development

No branches or pull requests

2 participants