Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable method chaining for after writeHead #1401

Merged
merged 1 commit into from Apr 5, 2024

Conversation

MamfTheKramf
Copy link
Contributor

writeHead now also returns a reference to the response object as specified here: https://nodejs.org/api/http.html#responsewriteheadstatuscode-statusmessage-headers

@MamfTheKramf MamfTheKramf marked this pull request as ready for review October 24, 2023 19:45
@lamweili lamweili linked an issue Oct 25, 2023 that may be closed by this pull request
@lamweili lamweili added this to the 6.9.2 milestone Oct 25, 2023
@lamweili lamweili added the bug Something isn't working label Oct 25, 2023
@lamweili lamweili changed the title Enable method chaining for after writeHead. fix: enable method chaining for after writeHead Oct 25, 2023
@lamweili lamweili merged commit bc59c87 into log4js-node:master Apr 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants