Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will date validation make it back in v3? #2247

Closed
kbirger opened this issue Aug 27, 2019 · 4 comments
Closed

Will date validation make it back in v3? #2247

kbirger opened this issue Aug 27, 2019 · 4 comments
Labels
❔ question More of an inquiry than an issue

Comments

@kbirger
Copy link

kbirger commented Aug 27, 2019

https://www.baianat.com/labs/code/veevalidate-3-0

Also we've removed some rules like the date validation due to them being very large, implementing them again will be trivial. These are the rules that have been altered/removed.

(Removed) date rules: after, before, date_format, date_between.

I'm having trouble understanding this note correctly. Does that mean that they will be implemented again in VeeValidate, or should I take that to mean "it's easy; go do it yourself from now on" ?

@logaretm logaretm added the ❔ question More of an inquiry than an issue label Aug 27, 2019
@logaretm
Copy link
Owner

Sorry if the wording was a little bit presumptuous. But to answer your question, no they won't come back.

I will provide some examples on date validation in a couple of days.

@jameshibbard
Copy link

jameshibbard commented Mar 27, 2020

Hi @logaretm,

I will provide some examples on date validation in a couple of days.

Did you ever do this? I'm currently trying to convert an app which uses v2 to use v3 and some examples of date validation would be mightily helpful. I couldn't find anything on the main site.

@tillsanders
Copy link
Contributor

@logaretm Would you explain your decision? Is it simply, that you consider this to be out of scope for vee-validate itself? Would you accept a pull request for additional rules like these?

@logaretm
Copy link
Owner

@tillsanders After maintaining the rules for a while now, I do wish vee-validate never included any rules by default as it would force the community to choose between already proven tools like validator.js or yup and built-in ones.

Having said that, v4 will move the rules to another package name so that they can be maintained individually from vee-validate itself. Maybe then I would consider adding more complex rules to the system.

The main reasons for this were the bundle size, hardly anyone used all these rules and very few did use the Date rules which required tons of configuration to work. I think it is easier this way to let it be userland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❔ question More of an inquiry than an issue
Projects
None yet
Development

No branches or pull requests

4 participants