feat: workspaces #2904
Merged
feat: workspaces #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR, Which IDEs are we talking about? it works fine in VSCode and I would imagine it works fine in others. Also, there seem to be some conflicts at the moment, could you fix them? |
|
It doesn't work in WebStorm, with workspaces enabled it works fine. Yes, I'll resolve the conflicts. |
Codecov Report
@@ Coverage Diff @@
## next #2904 +/- ##
=======================================
Coverage 97.99% 97.99%
=======================================
Files 48 48
Lines 947 947
Branches 207 207
=======================================
Hits 928 928
Misses 18 18
Partials 1 1 Continue to review full report at Codecov.
|
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃攷 Overview
Explain the premise for adding this PR and why is it important.
Ex (Feat): Introduce workspaces to resolve dependency issues.
The
nextbranch uses a workspaces-like folder structure but does not actually utilize workspaces feature in Yarn. This results invuebeing unknown for IDE autocompletion. This PR attempts to fix that.After the change
vueis resolved on a workspace global level.