Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): in case of radio or checkbox explicitly set initialValue #2907

Merged
merged 2 commits into from Sep 20, 2020
Merged

fix(core): in case of radio or checkbox explicitly set initialValue #2907

merged 2 commits into from Sep 20, 2020

Conversation

bzd2000
Copy link
Contributor

@bzd2000 bzd2000 commented Sep 19, 2020

馃攷 Overview

The initialValues are not taken into account for radio and also checkbox I think.

I proposed a fix + extra test case

closes #2906

@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #2907 into next will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2907      +/-   ##
==========================================
+ Coverage   97.99%   98.10%   +0.10%     
==========================================
  Files          48       48              
  Lines         947      949       +2     
  Branches      207      208       +1     
==========================================
+ Hits          928      931       +3     
+ Misses         18       17       -1     
  Partials        1        1              
Impacted Files Coverage 螖
packages/core/src/useField.ts 98.41% <100.00%> (+0.02%) 猬嗭笍
packages/core/src/utils/common.ts 98.18% <0.00%> (+1.81%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0c05f94...76c3569. Read the comment docs.

@logaretm logaretm merged commit e45ec82 into logaretm:next Sep 20, 2020
@logaretm logaretm linked an issue Sep 20, 2020 that may be closed by this pull request
@logaretm
Copy link
Owner

Thank you!

@logaretm logaretm linked an issue Feb 24, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants