Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent recursive re-render model update #2943

Merged
merged 3 commits into from Oct 8, 2020
Merged

fix: prevent recursive re-render model update #2943

merged 3 commits into from Oct 8, 2020

Conversation

logaretm
Copy link
Owner

@logaretm logaretm commented Oct 7, 2020

This PR introduces a simple re-render lock in the <Field /> component to prevent model updates if the most recent update was caused by a value change

closes #2941

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #2943 into next will increase coverage by 0.14%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2943      +/-   ##
==========================================
+ Coverage   97.35%   97.49%   +0.14%     
==========================================
  Files          48       48              
  Lines         983      999      +16     
  Branches      224      229       +5     
==========================================
+ Hits          957      974      +17     
+ Misses         25       24       -1     
  Partials        1        1              
Impacted Files Coverage Δ
packages/core/src/useField.ts 98.54% <94.11%> (+0.84%) ⬆️
packages/core/src/Field.ts 98.24% <100.00%> (+0.16%) ⬆️
packages/core/src/useForm.ts 98.71% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b29e72...255e749. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4] When using v-model on v-field - no character entered on first key press
1 participant